Comment Detail: Fix cell separators not aligning correctly after rotation #17451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #17087
As titled, this PR fixes the issue where sometimes the cell separator is still displaying the margins for the landscape orientation (around 67pt from the view edge) when the screen is already displayed in portrait (where it should be around 20pt). Here's a screenshot:
To Test
newCommentDetail
feature flag.Regression Notes
Potential unintended areas of impact
n/a. Feature is not released yet.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested to ensure that it behaves correctly.
What automated tests I added (or what prevented me from doing so)
n/a. Feature is not released yet.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Footnotes
Notice in the before image the content cell's right side is not aligned with the others, making it look asymmetrical since the right side is closer to the trailing edge. ↩ ↩2
Some of the cell separators overextended to the left side of the cells. ↩
Some cells have incorrect content insets / indentation level. This is due to the cell still using the margins in the landscape mode. ↩
Some of the cell separators overextended to the left side of the cells. ↩